Alphabetize messages #40
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #40 +/- ##
=====================================
Coverage 1.34% 1.34%
=====================================
Files 314 314
Lines 10536 10536
Branches 3628 3628
=====================================
Hits 142 142
Misses 8549 8549
Partials 1845 1845
Continue to review full report at Codecov.
|
| @@ -1,371 +1,368 @@ | |||
| id: en-US | |||
| name: English | |||
There was a problem hiding this comment.
I somewhat prefer having id and name on the first few lines of the i18n files.
Maybe we should nest all of the alphabetized components under a components key.
There was a problem hiding this comment.
I'm using https://github.com/akfernun/yaml-sortkeys to sort everything and would rather not make exceptions like this. FWIW, since every other first-level key is capitalized, these keys end up at the very bottom.
There was a problem hiding this comment.
@evansiroky, shall we just put underscores in front of id and name (_id and _name)? We'll need to change where these keys are called in config.js (I think only id is used at the moment).
There was a problem hiding this comment.
Prefixing with an underscore won't work because underscores have a higher char code than capital letters.
Please merge this!