Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Pydantic v2 and Ruff formatting #169

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update to Pydantic v2 and Ruff formatting #169

merged 3 commits into from
Nov 27, 2023

Conversation

zaneselvans
Copy link
Member

  • Minor changes to the code to use Pydantic v2. No tricky refactoring, all tests passed.
  • Switched from using black to ruff for autoformatting. Did not result in any changes.
  • Addressed or suppressed a variety of deprecation warnings that have been blowing up the logs in PUDL.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (713d1d7) 93.36% compared to head (2f5304a) 93.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   93.36%   93.41%   +0.04%     
==========================================
  Files           8        8              
  Lines         603      607       +4     
==========================================
+ Hits          563      567       +4     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade! Glad it was straightforward.

@jdangerx jdangerx merged commit 7fc8580 into main Nov 27, 2023
14 checks passed
@jdangerx jdangerx deleted the pydantic-v2 branch November 27, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants