Stop warning about duplicate record IDs & missing columns that don't matter #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FERC is not always consistent in its naming of corresponding columns that appear in both the instant & duration tables. This commit adds a renaming step to the default FERC1 process_instant_xbrl() and process_duration_xbrl() methods, that rename them early in the data transformations. This transform is parameterized using the same RenameColumns parameter and rename_columns() methods that we're using elsewhere.
zaneselvans
added
ferc1
Codecov ReportBase: 84.2% // Head: 84.2% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## xbrl_integration #2054 +/- ##
================================================
Coverage 84.2% 84.2%
================================================
Files 72 72
Lines 7972 7980 +8
================================================
+ Hits 6717 6724 +7
- Misses 1255 1256 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zaneselvans
changed the base branch from
plant-in-service-xbrl
to
xbrl_integration
14 tasks
cmgosnell
approved these changes
Nov 11, 2022
zaneselvans
changed the title
plant_in_service_ferc1 table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.