Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore improvements #715

Merged
merged 7 commits into from
Aug 17, 2020
Merged

Datastore improvements #715

merged 7 commits into from
Aug 17, 2020

Conversation

ptvirgo
Copy link
Contributor

@ptvirgo ptvirgo commented Aug 6, 2020

PR covers:
#708, #709

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #715 into sprint20 will increase coverage by 1.26%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           sprint20     #715      +/-   ##
============================================
+ Coverage     73.93%   75.19%   +1.26%     
============================================
  Files            39       39              
  Lines          4546     4825     +279     
============================================
+ Hits           3361     3628     +267     
- Misses         1185     1197      +12     
Impacted Files Coverage Δ
src/pudl/workspace/datastore.py 60.89% <75.00%> (+3.75%) ⬆️
src/pudl/transform/eia861.py 96.07% <0.00%> (-0.35%) ⬇️
src/pudl/constants.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6f736...f0928a9. Read the comment docs.

@zaneselvans zaneselvans changed the base branch from sprint20 to sprint21 August 10, 2020 23:30
@zaneselvans zaneselvans merged commit d4d0d33 into sprint21 Aug 17, 2020
@zaneselvans zaneselvans deleted the datastore_improvements branch August 27, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make datastore more robust Use relative rather than absolute paths in datastore datapackages
2 participants