Bugfixes for states=[ALL] and SQLite DB clobber check #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to address issue #870 which notes we're checking for the existence of an SQLAlchemy database URL, not a file path, when looking to see if we're clobbering an existing PUDL database. Also fixes a bug in which the special case of doing "ALL" states in the EPA CEMS processing was failing, since they were listed as dictionary keys, instead of a list or tuple.
Codecov Report
@@ Coverage Diff @@
## sprint29 #890 +/- ##
============================================
+ Coverage 74.57% 77.40% +2.83%
============================================
Files 44 44
Lines 5722 5722
============================================
+ Hits 4267 4429 +162
+ Misses 1455 1293 -162
Continue to review full report at Codecov.
|
The pudl_out object wasn't working with the new datastore arrangement since the call signatures had changed. Updated it to use the new datastore interface. Also moved the eia861 and ferc714 output / interim ETL tests into the fast_output_test module, since they only take a couple of minutes to run, and this will test more code -- including the stuff that was broken here.
The interim ETL functions for eia861 and ferc714 that are (temporarily, hackishly) embedded within the PUDL output object need to know where to look for the input data, which is a different place in CI than (typically) on our local machines. This commit tells that the fast_out object which is used for output testing (including running the interim ETL functions for eia861 and ferc714) to look at whatever datastore is within the pudl_datastore_fixture. Which still might not work because of the hardcoded PUDL_YML in pudl.workspace.datastore but we'll see.
cmgosnell
requested changes
Jan 20, 2021
For incompletely integrated data sources like ferc714 and eia861, we need to have access to a datastore within the PUDL output objects, so we can read the raw input files and run the interim ETL process. With this commit you can either pass in a Datastore object to use, or you leave it set to None, the __init__ method will use the default Datastore indicated by the user's .pudl.yml PUDL_IN path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address issue #870 which notes we're checking for the
existence of an SQLAlchemy database URL, not a file path, when looking
to see if we're clobbering an existing PUDL database.
Also fixes a bug in which the special case of doing "ALL" states in the
EPA CEMS processing was failing, since they were listed as dictionary
keys, instead of a list or tuple.