Skip to content

Commit

Permalink
Merge pull request #73 from catalystdao/coverage
Browse files Browse the repository at this point in the history
feat: enable coverage
  • Loading branch information
reednaa authored Dec 23, 2023
2 parents 321d80e + 51d30e0 commit e7cd23f
Show file tree
Hide file tree
Showing 12 changed files with 129 additions and 6,664 deletions.
4 changes: 1 addition & 3 deletions evm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,16 +120,14 @@ Compiling the tests takes a significant amount of time but running the tests the

## Coverage

Coverage currently doesn't work. It is unclear if this is an issue with Foundry or Solidity. The repository uses the Soldiity pipeline `--via-ir` to circumvent the *stack too deep* issue. The result is that when Foundry tries to re-compile the contracts without any optimisations it fails.
The repository uses the Soldiity pipeline `--via-ir` to circumvent the *stack too deep* issue. The result is that when Foundry tries to re-compile the contracts without any optimisations it fails.

The forge argument `-ir-minimum` has to be used to compile the contracts using the `ir` representation. Note that this changes the mapping of source code to compiled code and some sections can be incorrectled marked as uncovered or covered.

```
forge coverage --ir-minimum
```

Currently, this doesn't work.

# Deploying Catalyst

This repository contains a helper script for deployment `script/DeployCatalyst.s.sol` which is based on `script/DeployContracts.s.sol` which is the origin for most of the testing configuration. This deploys core swap contracts but not the cross-chain interface. This is instead done by `script/DeployInterfaces.s.sol` which also handles management/deployment of the dependency on [Generalised Incentives](https://github.com/catalystdao/GeneralisedIncentives).
Expand Down
1,945 changes: 0 additions & 1,945 deletions evm/poetry.lock

This file was deleted.

22 changes: 0 additions & 22 deletions evm/pyproject.toml

This file was deleted.

Loading

0 comments on commit e7cd23f

Please sign in to comment.