Change criteria for volumetric in Bruker tiff extractor #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
weiglszonja
reviewed
Jun 11, 2024
.github/workflows/run-tests.yml
Outdated
| @@ -38,7 +38,7 @@ jobs: | |||
| run: pytest tests/test_internals -n auto --dist loadscope | |||
|
|
|||
| - name: Test full installation (-e needed for codecov report) | |||
| run: pip install -e .[full] | |||
| run: pip install .[full] | |||
There was a problem hiding this comment.
It was left from another change. Mistake of mine.
That said, at some point we should remove those, they are not really necessary in the tests not even for codecov but that should be a separate PR. Let me remove.
weiglszonja
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks @h-mayorquin, I just had a comment on a change not sure is related here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #341
As described in #341 the current criteria that we use to determine if an image is volumetric is wrong.
mhturner proposed what I think is a very simple solution which I have implemented here. This fetches the sequence type and uses a simple dictionary to determine the nature of the data.
I tested this on volumetric data that I got from the Clandinin lab and this seems to be working.