optimize get streams for BrukerTiffSinglePlaneImagingExtractor
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…streams' into improve_bruker_get_streams
weiglszonja
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Looks good, thanks @h-mayorquin. Should we add this in the changelog?
Done. |
…streams' into improve_bruker_get_streams
weiglszonja
reviewed
Jun 12, 2024
Comment on lines
+346
to
+356
| channel_names = set() | ||
| for event, elem in ElementTree.iterparse(xml_file_path, events=("start",)): | ||
| if elem.tag == "Frame": | ||
| # Get all the sub-elements in this Frame element | ||
| for subelem in elem: | ||
| if subelem.tag == "File": | ||
| channel_names.add(subelem.attrib["channelName"]) | ||
|
|
||
| break | ||
|
|
||
| return channel_names |
There was a problem hiding this comment.
Would it make sense to switch to lxml as in #346 ?
There was a problem hiding this comment.
Good idea. Do you mind if I switch it in #346 just to avoid merging conficts? All of these PR are linked.
There was a problem hiding this comment.
Yeah, sounds good. thanks!
weiglszonja
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses lazy xml reading instead of parsing the whole xml file. On my data this implementation is 60 times faster.