Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Check Docstrings workflow to use new github action #354

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Update Check Docstrings workflow to use new github action #354

merged 5 commits into from
Aug 28, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Aug 23, 2024 •
edited
Loading

Updates roiextractors check-docstrings workflow based on catalystneuro/.github#19.

@pauladkisson pauladkisson marked this pull request as draft August 23, 2024 22:19
@pauladkisson pauladkisson marked this pull request as ready for review August 27, 2024 17:32
h-mayorquin
h-mayorquin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

h-mayorquin
h-mayorquin requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm failed to fetch for some reason : /

h-mayorquin
h-mayorquin approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the fix was simple.

@pauladkisson pauladkisson merged commit 58a398f into main Aug 28, 2024
29 checks passed
@pauladkisson pauladkisson deleted the test_check_docstrings branch August 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauladkisson @h-mayorquin