Fix build in GCC 7 #1407
Closed
Fix build in GCC 7 #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error is emitted by gcc 7.3:
include/internal/catch_tostring.cpp:217:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
| } else if ('\0' <= value && value < ' ') {
| ~~~~~^~~~~~~~
| cc1plus: all warnings being treated as errors
We can drop the first part of the if since '\0' == 0 and it will always
be <= than value of char (which is unsigned by default).
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
|
The PR #1399 fix is related to this PR. |
thecppzoo
reviewed
Oct 11, 2018
| @@ -214,7 +214,7 @@ std::string StringMaker<char>::convert(char value) { | |||
| return "'\\n'"; | |||
| } else if (value == '\t') { | |||
| return "'\\t'"; | |||
| } else if ('\0' <= value && value < ' ') { | |||
| } else if (value < ' ') { | |||
There was a problem hiding this comment.
This changes the semantics, whether char is signed is implementation defined. In some platforms their ABI may indicate char is unsigned, some others signed: In Visual C++ char is signed by default, in GCC unsigned...
I think the fix is to use this instead:
if(unsigned(value) < ' ')
|
Thanks, but I merged #1399 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error is emitted by gcc 7.3:
include/internal/catch_tostring.cpp:217:21: error: comparison is always true due to limited range of data type [-Werror=type-limits]
| } else if ('\0' <= value && value < ' ') {
| ~~~~~^~~~~~~~
| cc1plus: all warnings being treated as errors
We can drop the first part of the if since '\0' == 0 and it will always
be <= than value of char (which is unsigned by default).
Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com
Description
GitHub Issues