Command line parser should verify whether reporter is registered #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
==========================================
+ Coverage 80.23% 80.28% +0.05%
==========================================
Files 120 120
Lines 3394 3403 +9
==========================================
+ Hits 2723 2732 +9
Misses 671 671 |
|
Thanks for the PR. 👍 I performed some cosmetic changes to the commits, mainly squashing the superfluous last commit into its predecessor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1351
Introduced check during option parsing to validate whether reporter provided by the user is one of registered ones.
GitHub Issues
Related to #1351
I don't know why regression didn't start