Conan recipe Update + Conan package upload #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 80.31% 80.28% -0.02%
==========================================
Files 121 120 -1
Lines 3407 3403 -4
==========================================
- Hits 2736 2732 -4
Misses 671 671 |
horenmar
reviewed
Nov 16, 2018
|
So, if I understand it correctly, every push to master will build and upload a package, but it will be in "Testing" channel? |
|
no, every push on master will build to check the package consistence, but only tags will be uploaded. |
SSE4
suggested changes
Nov 17, 2018
|
I am going to squash this and merge it into master, unless someone objects. |
|
maybe wait for one more review from Conan team. They are at meetingc++ but they will be available on Monday. |
danimtb
approved these changes
Nov 19, 2018
|
I agree! |
- Apply new conventions introduced on Conan 1.8 - Removed outdated settings - Update license to follow SPDX format Closes catchorg#926 Closes catchorg#943
horenmar
force-pushed
the
feature/conanio
branch
from
bff0f8c to
ac0a83a
Compare
|
Ok, thanks everyone. |
|
Let's wait for the next release to have Catch2 on Bintray! Please, don't forget to configure your Conan password (Bintray API Key) on Travis settings. Regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 year after #943 🎂 I updated that PR creating a new one.
This PR includes:
What should be done to upload Conan packages after this PR?
The python package Conan Package Tools (CPT) is a helper to build and upload Conan package when some conditions are valid, this includes:
CONAN_PASSWORDon Travis CI settings (do not forget to set as secret). The password is the Bintray API Key, it can be collect on https://bintray.com/profile/edit, clicking on "API Key".CONAN_USERNAMEto be used on Conan package. By default is configured to catchorg, same organization name. The result will be Catch2/<version>@catchorg/stableCONAN_LOGIN_USERNAMEto be used on Bintray login. By default is philsquared.CONAN_UPLOADto configure remote address where the package might be uploaded. By default is https://bintray.com/philsquared/Catch2Thus the only requirement is
CONAN_PASSWORDin Travis settings. All other variables are configured as needed.GitHub Issues
closes #926
closes #943
Adding some Conan experts to review:
/cc @memsharded @danimtb @Croydon @SSE4
Regards!