Remove redundant move #1474
Merged
Remove redundant move #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see on Travis, it is not quite redundant enough if you are using older gcc+libstdc++ combination. |
|
@horenmar Yes, I see, may be we can add conditionals for checking Clang >= 3.9 and gcc >= 5 to enable it. Otherwise keep the std::move |
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
+ Coverage 80.38% 80.39% +0.01%
==========================================
Files 121 121
Lines 3425 3426 +1
==========================================
+ Hits 2753 2754 +1
Misses 672 672 |
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
+ Coverage 80.38% 80.42% +0.04%
==========================================
Files 121 121
Lines 3425 3422 -3
==========================================
- Hits 2753 2752 -1
+ Misses 672 670 -2 |
|
I took a slightly different approach, can you check if it eliminates the warning on your machine? |
The alternate approach works for me. Tested- by: Khem Raj raj.khem@gmail.com |
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
Ok, great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes errors like below
/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/catch2/2.5.0-r0/git/include/internal/catch_session.cpp:52:29:
error: redundant move in return statement [-Werror=redundant-move]
52 | return std::move(multi);
| ~~~~~~~~~^~~~~~~
/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/catch2/2.5.0-r0/git/include/internal/catch_session.cpp:52:29:
note: remove 'std::move' call
Signed-off-by: Khem Raj raj.khem@gmail.com
Description
GitHub Issues