fix ctest output with space before name #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PARSE_CATCH_TESTS_ADD_TARGET_IN_TEST_NAME is enabled the cmake helper script fails to extract the testcase name if a whitespace is before the name string. Use regex to consider and remove this whitespace. fix by Mike-Devel fixes: catchorg#1493
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
======================================
Coverage 80.4% 80.4%
======================================
Files 121 121
Lines 3428 3428
======================================
Hits 2756 2756
Misses 672 672 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
======================================
Coverage 80.4% 80.4%
======================================
Files 121 121
Lines 3428 3428
======================================
Hits 2756 2756
Misses 672 672 |
|
Thanks |
horenmar
added
the
Extras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When PARSE_CATCH_TESTS_ADD_TARGET_IN_TEST_NAME is enabled the cmake helper script fails to extract the testcase name if a whitespace is before the name string. Use regex to consider and remove this whitespace.
GitHub Issues
#1493