WIP: Generators take 2 #1516
Merged
WIP: Generators take 2 #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 80.53% 80.62% +0.09%
==========================================
Files 121 120 -1
Lines 3436 3374 -62
==========================================
- Hits 2767 2720 -47
+ Misses 669 654 -15 |
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 80.38% 80.54% +0.17%
==========================================
Files 121 121
Lines 3409 3377 -32
==========================================
- Hits 2740 2720 -20
+ Misses 669 657 -12 |
JoeyGrajciar
requested changes
Jan 28, 2019
|
I've added the generic generator adapters I've wanted to add, now I need to add some examples and documentation. |
horenmar
force-pushed
the
dev-generators-take2
branch
2 times, most recently
from
91030e3 to
5fa21dc
Compare
JoeyGrajciar
approved these changes
Jan 29, 2019
This means mutiple generic generators and some inference helper * take(n, generator) * filter(predicate, generator) * map(func, generator) * repeat(generator, repeats)
horenmar
force-pushed
the
dev-generators-take2
branch
from
6c47de5 to
061f1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the generator interface to only require "Input" generators, as opposed to the old interface, that required "RandomAccess" generators. This means that the new interface can be easily fulfilled by generators that can only be iterated once per construction and only know whether they have more inputs when they try to prepare the next one, such as generators that read inputs from a file.
I am planning to add some extra generator adapters and more custom generator examples before merging this, but I want review for the design now.
Issues
N/A