Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TAP protocol reporter #1529

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

berkus
Copy link
Contributor

@berkus berkus commented Feb 4, 2019

According to TAP protocol version 13, the comments after the test name
only may contain Directives - # TODO or # SKIP. We should put
the comment (aka suite name) on a separate line before the test.

See http://testanything.org/tap-version-13-specification.html#directives

According to TAP protocol version 13, the comments after the test name
only may contain Directives - # TODO or # SKIP. We should put
the comment (aka suite name) on a separate line before the test.

See http://testanything.org/tap-version-13-specification.html#directives
@berkus
Copy link
Contributor Author

berkus commented Feb 5, 2019

Fail is due to travis-ci valgring builder being broken? Not related to code.

@JoeyGrajciar JoeyGrajciar merged commit dd3d27d into catchorg:master Feb 8, 2019
@berkus berkus deleted the fix-tap-reports branch February 8, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants