Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseAndAddCatchTests enhancements #1559

Merged
merged 5 commits into from
Apr 10, 2019

Conversation

drdanz
Copy link
Contributor

@drdanz drdanz commented Mar 7, 2019

A few enhancements to the ParseAndAddCatchTests CMake module:

Set the ParseAndAddCatchTests_TESTS property

After the script, the ParseAndAddCatchTests_TESTS property for the target, and for each source file in the target is set, and contains the list of the tests extracted from that target, or from that file.
This is useful, for example to add further labels or properties to the tests.

Fix tests not found

When using an optional launcher the target name is not interpreted as a target, therefore it is not replaced automatically with its path.

Document AdditionalCatchParameters variable

Add scope to functions in order to avoid name collisions

Do not change CMAKE_MINIMUM_REQUIRED_VERSION when included

drdanz added 3 commits March 7, 2019 15:07
After the script, the ParseAndAddCatchTests_TESTS property for the
target, and for each source file in the target is set, and contains the
list of the tests extracted from that target, or from that file.

This is useful, for example to add further labels or properties to the
tests.
When using an optional launcher the target name is not interpreted as a
target, therefore it is not replaced automatically with its path.
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1559 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
- Coverage   80.72%   80.58%   -0.14%     
==========================================
  Files         121      121              
  Lines        3423     3399      -24     
==========================================
- Hits         2763     2739      -24     
  Misses        660      660

@drdanz drdanz force-pushed the ParseAndAddCatchTests_enhancements branch from 6ce718a to 2ec0960 Compare March 7, 2019 15:03
@horenmar horenmar added the Extras Touches utility scripts outside of Catch2 proper, e.g. CMake integration. label Apr 10, 2019
@horenmar
Copy link
Member

Thanks

@horenmar horenmar merged commit 1e2270b into catchorg:master Apr 10, 2019
@drdanz drdanz deleted the ParseAndAddCatchTests_enhancements branch April 10, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extras Touches utility scripts outside of Catch2 proper, e.g. CMake integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants