Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't define tryTranslators function if exception are disabled #2726

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Don't define tryTranslators function if exception are disabled #2726

merged 1 commit into from
Aug 4, 2023

Conversation

VitaliiTrubchaninovUbisoft
Copy link
Contributor

"-Wunused-function -Wall" produces if this function is defined when exceptions are disabled

Description

GitHub Issues

"-Wunused-function -Wall" produces if this function is defined when exceptions are disabled
@VitaliiTrubchaninovUbisoft
Copy link
Contributor Author

appveyor build break is not related to my changes.
CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
Could NOT find PythonInterp: Found unsuitable version "2.7.17", but
required is at least "3" (found C:/Python27/python.exe)
Call Stack (most recent call first):

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2726 (267f9c1) into devel (4acc518) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2726      +/-   ##
==========================================
- Coverage   91.20%   91.19%   -0.01%     
==========================================
  Files         192      192              
  Lines        7843     7843              
==========================================
- Hits         7153     7152       -1     
- Misses        690      691       +1     

@horenmar
Copy link
Member

horenmar commented Aug 4, 2023

Thanks.

@horenmar horenmar merged commit ed4acde into catchorg:devel Aug 4, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants