Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add bazel build rule for SelfTest #2857

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Apr 16, 2024

Description

This PR primarily accomplishes two tasks:

  1. It adds MODULE.bazel.lock to the .gitignore file.
  2. It includes a Bazel build rule for SelfTest, which can be utilized with the command bazel test //tests:catch2_self_test.

GitHub Issues

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (53ddf37) to head (31b9a3a).
Report is 2 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2857   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         197      197           
  Lines        8382     8382           
=======================================
  Hits         7635     7635           
  Misses        747      747           

@horenmar
Copy link
Member

What's the advantage of having SelfTest build rule in repo, when the main development is done using CMake?

@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Apr 20, 2024
@c8ef
Copy link
Contributor Author

c8ef commented Apr 20, 2024

There may not be much advantage, but I noticed the meson build file for the test case. I believe it would be beneficial to have a corresponding Bazel build rule for those using Bazel.

@horenmar
Copy link
Member

Fair enough.

@horenmar horenmar merged commit 2bce3e2 into catchorg:devel Apr 21, 2024
81 checks passed
@c8ef
Copy link
Contributor Author

c8ef commented Apr 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants