Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conanfile: fix cmake_target_name of Catch2::Catch2. #2861

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

vsaulue
Copy link
Contributor

@vsaulue vsaulue commented Apr 18, 2024

Description

The "Catch2 without default main" target doesn't have a specific name in Conan, and defaults to catch2::catch2base. This commit switches it back to Catch2::Catch2, as described in the docs.

The "Catch2 without default main" target is currently unspecified in
Conan, and defaults to catch2::catch2base. This commit switches it back
to Catch2::Catch2, as specified in the docs.
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (53ddf37) to head (7e7c64b).
Report is 2 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2861      +/-   ##
==========================================
+ Coverage   91.09%   91.10%   +0.01%     
==========================================
  Files         197      197              
  Lines        8382     8382              
==========================================
+ Hits         7635     7636       +1     
+ Misses        747      746       -1     

@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Apr 20, 2024
@horenmar
Copy link
Member

Thanks

@horenmar horenmar merged commit df04df9 into catchorg:devel Apr 20, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants