Add opt-in c++11 stream insertable check. #877
Merged
+68
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should explain the toggle in I'll fix-up whitespace and fmt later. |
CATCH_CONFIG_CPP11_STREAM_INSERTABLE_CHECK needs to be defined.
|
I added explanation and removed weird underscore between |
|
It's in and I have to say, I honestly can't wait till Catch Classic is put into legacy mode, there is way too many C++11 toggles to test properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds opt-in define
CATCH_CONFIG_CPP_11_STREAM_INSERTABLE_CHECKfor enabling C++11 stream insertable check which should be better in some cases as suggested by @philsquared in #872.All current tests seem to pass fine with it on my system.
Should I also add it to documentation somewhere?
PR should resolve #872 and #757 for those who opt-in.