Merge pull request #2549 from WPO-Foundation/2548

2548 - handle find/replace differently than other swaps so we don't interfere with the other swaps
catchpoint · Nov 30, 2022 · 8d9569c · 8d9569c
2 parents 4c99979 + b18624b
commit 8d9569c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/www/experiments/custom.inc b/www/experiments/custom.inc
@@ -40,7 +40,7 @@ $assessment[$category]["opportunities"][] = array(
             'id' => '026',
             'title' => 'Find/Replace Text',
             "desc" => '<p>This experiment will find and replace occurrences of text in the page, with the option of using regular expressions, capturing parentheses, and flags as well</p>',
-            "expvar" => 'swap',
+            "expvar" => 'findreplace',
             "expfields" => array(
                 (object) [
                     'label' => 'find',

diff --git a/www/runtest.php b/www/runtest.php
@@ -975,7 +975,6 @@ function buildSelfHost($hosts)
                     ) {
                         $error = "Attempt to use unauthorized experiments feature.";
                     } else {
-                        $recipeScript .= $recipeSansId;
                         $experimentSpof = array();
                         $experimentBlock = array();
                         $experimentOverrideHost = array();
@@ -997,8 +996,10 @@ function buildSelfHost($hosts)
                                 if ($recipeSansId === "setinitialurl") {
                                     $experimentRunURL = $ingredients;
                                 }
-                                if ($recipeSansId === "swap") {
-                                    $experimentSwap = $ingredients;
+                                if ($recipeSansId === "findreplace") {
+                                    // findreplace is used in the form to submit the pieces for a swap experiment.
+                                    // we don't need that term from here. we'll build the swap.
+                                    $recipeSansId === "swap"
                                     if ($ingredients[0]) {
                                         $ingredients[0] = rawurlencode($ingredients[0]);
                                     }
@@ -1020,7 +1021,7 @@ function buildSelfHost($hosts)
                             ) {
                                 $ingredients = rawurlencode($ingredients);
                             }
-                            $recipeScript .= ":=" . $ingredients;
+                            $recipeScript .= "$recipeSansId:=" . $ingredients;
                         }
                         $recipeScript .= ";";
                     }