Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare page header sometimes shows when it should be hidden, such as when comparing two tests with different IDs that are not experiments. #2324

Closed
scottjehl opened this issue Sep 6, 2022 · 1 comment
Assignees
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest

Comments

@scottjehl
Copy link
Contributor

The regression seemed to come from this unrelated commit. Maybe we can make the if condition contingent on $tests being undefined?

5926f1d

@scottjehl scottjehl added the Type: Bug An issue or pull request relating to a bug in WebPageTest label Sep 6, 2022
@scottjehl
Copy link
Contributor Author

Tim this seems to do the trick but I'm not familiar enough with the original commit's goals.

if (isset($test['test']['completeTime']) || (!isset($tests) && file_exists("$testPath/test.complete") ) ) {

scottjehl added a commit that referenced this issue Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest
Projects
None yet
Development

No branches or pull requests

2 participants