Priority hint LCP experiment stopped showing unless the image has a fetchPriority attr already #2421
Assignees
Labels
Type: Bug
An issue or pull request relating to a bug in WebPageTest
Comments
scottjehl
added
the
Type: Bug
tkadlec
added a commit
that referenced
this issue
Oct 5, 2022
Fixes #2421 - LCP priority hint experiment suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this change knocked it out of the suggestions for any image that doesn't have a fetchPriority attribute in the markup.
b7931d2
Both of these work instead.
if (!$isBG && !$isVideo && !isset($lcp['element']['fetchPriority']) || $lcp['element']['fetchPriority'] != 'high') {or
if (!$isBG && !$isVideo && !(isset($lcp['element']['fetchPriority']) && $lcp['element']['fetchPriority'] == 'high')) {I think the second one is better because we should show this experiment if there's a fetchPriority="low" on there for some reason.
The text was updated successfully, but these errors were encountered: