Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap experiments should support multiples on the runtest.php side #2548

Closed
scottjehl opened this issue Nov 28, 2022 · 0 comments
Closed

Swap experiments should support multiples on the runtest.php side #2548

scottjehl opened this issue Nov 28, 2022 · 0 comments
Assignees
@scottjehl
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest

Comments

@scottjehl
Copy link
Contributor

The swap experiment is currently parsed in runtest as if it is coming from the find/replace experiment, which uses swap, but that experiment actually is an edge case that uses a few fields to build a swap experiment value. Instead, let's rename that find/replace experiment to something unique like "findreplace" so that runtest can handle it specifically without messing with other swap experiments that are in the form (meta viewport is one).
@scottjehl scottjehl added the Type: Bug An issue or pull request relating to a bug in WebPageTest label Nov 28, 2022
@scottjehl scottjehl self-assigned this Nov 28, 2022
scottjehl added a commit that referenced this issue Nov 28, 2022
@scottjehl
rename the experiment that builds a swap experiment from fields to fi…
3631351 
…ndreplace #2548
@scottjehl scottjehl mentioned this issue Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottjehl scottjehl

Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scottjehl