Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prod #1709

Merged
merged 16 commits into from
Jan 31, 2022
Merged

update prod #1709

merged 16 commits into from
Jan 31, 2022

Conversation

scottjehl
Copy link
Contributor

No description provided.

jefflembeck and others added 16 commits January 28, 2022 11:54
@jefflembeck
chore(standards): follow PSR-1 for method names
1f52882
@jefflembeck
feat(context): add User instance to $request
5d26239 
This allows us to use $request->getUser() throughout the code to get the
current user.

This will be helpful when we're managing logging in locally
@jefflembeck
chore(psr12): keep standards with PSR12
8fa3f38
@jefflembeck
chore(psr12): keep standards with PSR12
1a36865
@jefflembeck
Merge pull request #1665 from WPO-Foundation/attach-user
f411075 
feat(context): add User instance to $request
@jefflembeck
feat(client): add a catchpoint client
87f723d 
Include methods for authentication, this involves logging in, refreshing
a token, and revoking a token
@jefflembeck
feat(client): attach client
8f21103
@jefflembeck
Merge pull request #1666 from WPO-Foundation/cp-client
9478f5f 
feat: Adding a CP Client
@scottjehl
styles to support a dense detail table. Also, elimate unnecessary y o…
20f593d 
…verflow on th for the table
@scottjehl
Support for optionally enabling cols for detail view
1403269
@scottjehl
detail view to use additional columns and fixes #1696
274bc2b
@scottjehl
This change removes a max-height on overflow tables, which will mean …
6ccfb33 
…that column headers will no longer be able to stick as you scroll.

We'd debated having sticky column headers and decided it's better than not in many cases, but the downsides are tables can have overflow that's not immediately obvious. For now, we can disable this for the vertical heights. Horizontal overflow will still have sticky row headers, which is more crucial on mobile sizes.
@tkadlec
Merge pull request #1708 from WPO-Foundation/v-table-max
eba6ce7 
Remove sticky column headers (and the vertical scroll as well) on overflow tables.
@tkadlec
Merge pull request #1707 from WPO-Foundation/1696
4f960ef 
1696
@scottjehl
this blend mode was interfering with the waterfall opacity sliders. D…
890dd63 
…isabled in the filmstrip layout
@scottjehl
css version
998ab3a
jefflembeck
jefflembeck approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOO

@scottjehl scottjehl merged commit ec722f2 into prod Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottjehl @jefflembeck @tkadlec