Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Median run for menu nav #1713

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Median run for menu nav #1713

merged 1 commit into from
Feb 1, 2022

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented Feb 1, 2022

This fixes #1712 by ensuring we always use the median run for the menu navigation.

scottjehl
scottjehl approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@scottjehl scottjehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @tkadlec! Nice catch.

Quick check: does the thumbnail image include line up with the expected run? I think it does...

@tkadlec
Copy link
Contributor Author

tkadlec commented Feb 1, 2022

Just verified and yeah, it looks like it's correct as is.

@tkadlec tkadlec merged commit 7b420af into master Feb 1, 2022
@scottjehl scottjehl deleted the fix-median-run-menu-links branch February 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjehl scottjehl scottjehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vitals Link not using median run
2 participants
@tkadlec @scottjehl