Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CP RUM #1834

Merged
merged 2 commits into from
May 11, 2022
Merged

Add CP RUM #1834

merged 2 commits into from
May 11, 2022

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented May 11, 2022

This one adds CP RUM to our site. Just makes sense for us to walk the walk here, but also we want this so we can see the impact of some of the stuff we do.

@tkadlec tkadlec requested a review from jefflembeck May 11, 2022 14:11
jefflembeck
jefflembeck approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ok. but also can we maybe wrap it in an anonymous function so it doesn't pollute the global or does it need the scope?

@tkadlec
Copy link
Contributor Author

tkadlec commented May 11, 2022

testing now....

@tkadlec
Copy link
Contributor Author

tkadlec commented May 11, 2022

Payload looked identical, so I'm gonna keep it wrapped we can ship the tidy way.

@tkadlec tkadlec merged commit 53ceec4 into master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkadlec @jefflembeck