Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitialOrigin will be used to pair the setCookie with the eventual non-redirect host #1981

Merged
merged 3 commits into from
Jun 6, 2022
Merged

InitialOrigin will be used to pair the setCookie with the eventual non-redirect host #1981

merged 3 commits into from
Jun 6, 2022

Conversation

scottjehl
Copy link
Contributor

No description provided.

@scottjehl
Copy link
Contributor Author

showing in this case, an origin without www and the host and cookie picking up the eventual redirected www to use
image

@scottjehl scottjehl requested a review from tkadlec June 6, 2022 22:54
jefflembeck
jefflembeck reviewed Jun 6, 2022
View reviewed changes
www/runtest.php Outdated Show resolved Hide resolved
jefflembeck
jefflembeck approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems sound

@scottjehl @jefflembeck
Update www/runtest.php
674d2ca 
Co-authored-by: Jeff Lembeck <jlembeck@gmail.com>
@scottjehl scottjehl merged commit 12c9356 into master Jun 6, 2022
@scottjehl scottjehl deleted the redirect-host-cookie branch June 6, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

@tkadlec tkadlec Awaiting requested review from tkadlec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottjehl @jefflembeck