Surface extensions in the UI #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks great to me. +1 to get this into the form, then later into opps and experiments. |
jefflembeck
approved these changes
Sep 7, 2022
|
merging now, we'll address top X extensions separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent work was done by @pmeenan a while ago: catchpoint/WebPageTest.agent@5e0b900
This implementation lists the top X extensions. Where X is 12, as seen in the chrome web store homepage as "recommended for you" loaded in incognito. Looking at https://chrome.google.com/webstore/category/recommended_extensions now (as opposed to last week) seems things change pretty rapidly, so we might need a better way to get the top X
This is the new UI in the Chrome tab:
Test results: