Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make "add html to end of head" experiment free #2411

Merged
merged 1 commit into from
Oct 4, 2022
Merged

make "add html to end of head" experiment free #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion www/experiments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ function observationHTML($parts)
global $test;
global $experiments_paid;
global $experiments_logged_in;
$allowedFreeExperimentIds = array('001','020');

$bottleneckTitle = $parts["title"];

Expand Down Expand Up @@ -243,7 +244,7 @@ function observationHTML($parts)
}

// experiments are enabled for the following criteria
$experimentEnabled = $experiments_paid || ($expNum === "001" && $experiments_logged_in);
$experimentEnabled = $experiments_paid || ( in_array($expNum, $allowedFreeExperimentIds) && $experiments_logged_in);
// exception allowed for tests on the metric times
if (strpos($test['testinfo']['url'], 'webpagetest.org/themetrictimes') && $experiments_logged_in) {
$experimentEnabled = true;
Expand Down
2 changes: 1 addition & 1 deletion www/runtest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ function buildSelfHost($hosts)
$recipeScript = '';
$experimentSpof = "";
$experimentBlock = "";
$allowedFreeExperimentIds = array('001');
$allowedFreeExperimentIds = array('001', '020');
foreach ($req_recipes as $key => $value) {
// optional, but the experiments page prefixes recipe names with an index and a dash to keep ingredients paired with an opportunity's recipe name
// also, for wpt params (liks spof, block) meant to run on only experiment runs, there's a experiment- prefix after the number
Expand Down