Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload constants.inc #2434

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Autoload constants.inc #2434

merged 1 commit into from
Oct 6, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Oct 6, 2022

As part of the transition off __DIR__ includes, make the *_PATH constants always available by adding them to autoload.

Ran composer dump-autoload, tested with composer test to make sure the WWW_PATH is available in tests

Browsed the site after removing the explicit require for constants.inc to make sure it's not broken and constants are all defined.

composer dump-autoload made some changes, hope they look ok.

@stoyan stoyan requested a review from jefflembeck October 6, 2022 16:55
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOO. That's really nice.

@stoyan stoyan merged commit bb75d67 into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants