Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __DIR__ use (in 30 out of 120-ish files) #2448

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix __DIR__ use (in 30 out of 120-ish files) #2448

merged 2 commits into from
Oct 18, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Oct 7, 2022

Includes of common.inc and autoload.php need to remain with DIR for now, as the constants are not yet loaded.

Will address the rest of the instances in follow up diffs, let's see what this one breaks.

@stoyan stoyan requested a review from jefflembeck October 11, 2022 22:54
www/consolelog.php Outdated Show resolved Hide resolved
@stoyan stoyan requested a review from jefflembeck October 17, 2022 19:44
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and will be really helpful

@stoyan stoyan merged commit d3b869f into master Oct 18, 2022
@stoyan stoyan deleted the constantia branch October 18, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants