Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collection period in CrUX Real User Measurement title. #2476

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Added collection period in CrUX Real User Measurement title. #2476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55790d
Added collection period in CrUX Real User Measurement title.
sammeboy635 Oct 17, 2022
d2e3b99
composer format
sammeboy635 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion www/include/CrUX.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,30 @@ function PruneCruxCache()
}
}
}
// returns a string of the Real User Measurement title for results.php if CrUX has collectionPeriod
function RealUserMeasurementCruxTitle($pageData)
{
if (
isset($pageData['CrUX']['collectionPeriod']) &&
isset($pageData['CrUX']['collectionPeriod']['firstDate']) &&
isset($pageData['CrUX']['collectionPeriod']['lastDate'])
) {
$firstDate = $pageData['CrUX']['collectionPeriod']['firstDate'];
$lastDate = $pageData['CrUX']['collectionPeriod']['lastDate'];
$startDate = date('F j\, Y', mktime(0, 0, 0, $firstDate['month'], $firstDate['day'], $firstDate['year']));
$endDate = date('F j\, Y', mktime(0, 0, 0, $lastDate['month'], $lastDate['day'], $lastDate['year']));
// Example: Real User Measurements (Collected anonymously by Chrome browser via Chrome User Experience Report, between October 15, 2022 and September 18, 2022)
return sprintf('<h3 class="hed_sub">
Real User Measurements
<em>(Collected anonymously by Chrome browser via Chrome User Experience Report, between %s and %s)</em>
</h3>', $startDate, $endDate);
} else {
return '<h3 class="hed_sub">
Real User Measurements
<em>(Collected anonymously by Chrome browser via Chrome User Experience Report)</em>
</h3>';
}
}

function InsertCruxHTML($fvRunResults, $rvRunResults, $metric = '', $includeLabels = true, $includeMetricName = true)
{
Expand Down Expand Up @@ -108,7 +132,7 @@ function InsertCruxHTML($fvRunResults, $rvRunResults, $metric = '', $includeLabe
$cruxStyles = true;
}
echo '<div class="crux">';
echo '<h3 class="hed_sub">Real User Measurements <em>(Collected anonymously by Chrome browser via Chrome User Experience Report.)</em></h3>';
echo RealUserMeasurementCruxTitle($pageData);
echo '<div class="crux_legends"><strong>WPT\'s Metrics for comparison:</strong>';
if (isset($pageData) && (isset($pageData['chromeUserTiming.firstContentfulPaint']) || isset($pageData['chromeUserTiming.LargestContentfulPaint']) || isset($pageData['chromeUserTiming.CumulativeLayoutShift']))) {
echo ' &nbsp;<span class="legend"><span class="fvarrow">&#x25BC</span> ';
Expand Down