HTML diff results page #2535
Merged
HTML diff results page #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THIS IS AMAZING |
stoyan
commented
Nov 17, 2022
Comment on lines
68
to
90
| const fragment = document.createDocumentFragment(); | ||
| for (let i = 0; i < diff.length; i++) { | ||
|
|
||
| if (diff[i].added && diff[i + 1] && diff[i + 1].removed) { | ||
| let swap = diff[i]; | ||
| diff[i] = diff[i + 1]; | ||
| diff[i + 1] = swap; | ||
| } | ||
|
|
||
| let node; | ||
| if (diff[i].removed) { | ||
| node = document.createElement('del'); | ||
| node.appendChild(document.createTextNode(diff[i].value)); | ||
| } else if (diff[i].added) { | ||
| node = document.createElement('ins'); | ||
| node.appendChild(document.createTextNode(diff[i].value)); | ||
| } else { | ||
| node = document.createTextNode(diff[i].value); | ||
| } | ||
| fragment.appendChild(node); | ||
| } | ||
| document.getElementById('diff-result').innerHTML = ''; | ||
| document.getElementById('diff-result').appendChild(fragment); |
|
Looks great |
scottjehl
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of an HTML diff between HTML over the wire and
documentElement.outerHTML. Works only is "save response bodies" is checked, otherwise we only have the rendered HTML.The diff is performed on the client side via https://www.npmjs.com/package/diff (<8k payload)
Optionally we can format with Prettier (350k, loaded on demand only if the checkbox is checked)
error state
Normal view
couple of annoyances
Not terrible when Prettier pre-formats, but otherwise pretty distracting because we lose the new lines and the diff goes wild
without Prettier
with Prettier