Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Login on LH results #2619

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix Login on LH results #2619

merged 1 commit into from
Jan 5, 2023

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Jan 5, 2023

Looks like we were including common.inc twice which probably resets some checks.

As a result the page loads in signed out state

Fix Login on LH results
6000ae5 
Looks like we were including `common.inc` twice which probably resets
some checks.
@stoyan Microsoft Teams for GitHub
Copy link
Contributor Author

stoyan commented Jan 5, 2023

btw, I chose to _once rather than delete the include because lighthouse-new.php works as a standalone page too

@stoyan stoyan merged commit d78edfd into master Jan 5, 2023
@stoyan stoyan deleted the lhlogin branch January 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

@scottjehl scottjehl Awaiting requested review from scottjehl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoyan @jefflembeck