Adding Moto G Power #2809
Merged
Adding Moto G Power #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point, we should look at making this the default. But I think we want to be careful about communicating it since anyone running default tests without specifying the mobile device will see different metrics than they're used to. |
stoyan
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse recently changed their default device to the Moto G Power (GoogleChrome/lighthouse#14674). This means we have a situation where our default device (the G4) has a much smaller viewport, causing some sizable differences in what folks may see in our LH runs and WPT runs.
This adds the Moto G Power. Using a 7.5x CPU throttling factor seems about right.
A referenced Speedometer 2.0 benchmark on a real device came in at 14.1 +/- 0.21. A few quick tests at 7.5 returned: 14.5, 13.9, 14.1