Access-Control-Allow-Origin
in LH JSON exports
#2842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do it for a bunch of other JSON exports, see function
json_response()
in common_lib.inc:https://github.com/WPO-Foundation/webpagetest/blob/master/www/common_lib.inc#L2642
Testing with the new LH diff tool:
https://googlechrome.github.io/lighthouse-ci/difftool/?baseReport=https://gist.githubusercontent.com/paulirish/c149ae183349e330e82cc99836095eb2/raw/8eb6666da6e5d3eb0b15fff0aefa216de0c172aa/www.mikescerealshack.co_2022-03-15_14-49-33.lighthouse.report.json&compareReport=https%3A%2F%2Fwww.webpagetest.org%2Flighthouse.php%3Ftest%3D221214_BiDcSF_CRE%26f%3Djson
Before: fetch error
After: nice diff