Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid lines not displaying #3003

Closed
wants to merge 9 commits into from
Closed

Grid lines not displaying #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b419c7f
Removing div and classes
Oct 31, 2023
4a39b10
Merge pull request #2995 from v-hclaveria/grid_lines_not_displaying_t…
claud-io Nov 9, 2023
c05fc6c
Scrollable cell for firefox
Nov 9, 2023
91796d6
Conflict resolved
Nov 10, 2023
058e28e
Merge branch 'grid_lines_not_displaying' into scrollbar_firefox
v-hclaveria Nov 10, 2023
efe1fe3
Display scrollbar only if necessary
Nov 10, 2023
b6bba52
Adjustment single div
Nov 10, 2023
c8e8cff
Fix format
Nov 16, 2023
9ea8328
Merge pull request #3005 from v-hclaveria/scrollbar_firefox
claud-io Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions www/assets/css/pagestyle2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6643,6 +6643,15 @@ div.overflow-container > *,
position: relative;
}

.scrollable-location {
padding: unset;
}

.scrollable-location-content {
overflow-x: auto;
padding: 1em;
}

span.units {
font-size: 0.5em;
font-weight: 300;
Expand Down
53 changes: 25 additions & 28 deletions www/resources/views/pages/testhistory.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,34 +35,31 @@
<div class="history-controls">
<input id="CompareBtn" type="submit" value="Compare Selected Tests">
</div>
<div class="scrollableTable">
<table id="history" class="history pretty" border="0" cellpadding="5px" cellspacing="0">
<thead>
<tr>
<th class="pin"><span>Select to compare</span></th>
<th class="url">URL</th>
<th class="date">Run Date</th>
<th class="location">Run From</th>
<th class="label">Label</th>
</tr>
</thead>
@if ($is_logged_in)
<tbody id="historyBody">
@foreach ($test_history as $record)
<tr>
<th><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
<td class="url"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></td>
<td class="date">{{ date_format(date_create($record->getStartTime()), 'M d, Y g:i:s A e') }}</td>
<td class="location">{{ $record->getLocation() }}</td>
<td class="label">{{ $record->getLabel() }}</td>
</tr>
@endforeach
</tbody>
@endif
</table>
</div>


<table id="history" class="history pretty" border="0" cellpadding="5px" cellspacing="0">
<thead>
<tr>
<th><span>Select to compare</span></th>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's reason to remove pin class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-hclaveria bump on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin class has the property border-left: 0, disappearing the left line of the box
image

<th class="url">URL</th>
<th class="date">Run Date</th>
<th class="location">Run From</th>
<th class="label">Label</th>
</tr>
</thead>
@if ($is_logged_in)
<tbody id="historyBody">
@foreach ($test_history as $record)
<tr>
<th><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
<td class="url"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></td>
<td class="date">{{ date_format(date_create($record->getStartTime()), 'M d, Y g:i:s A e') }}</td>
<td class="location scrollable-location"><div class="scrollable-location-content">{{ $record->getLocation() }}</div></td>
<td class="label">{{ $record->getLabel() }}</td>
</tr>
@endforeach
</tbody>
@endif
</table>

@if ($local)
<input type="hidden" name="local" value="1">
@endif
Expand Down
Loading