Updated iPhone/iPad mobile devices #3004
Merged
+483
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to change the trhottle factor for the existing Android devices? Those are the baselines that you should be setting other throttles from because they were calibrated on real devices. |
|
@pmeenan those two files www/settings/mobile_devices.ini docker/local/server/config/mobile_devices.ini are different, which one is correct? |
|
I'm not sure why the docker container has a separate copy but the Change LGTM |
pmeenan
approved these changes
Nov 9, 2023
|
@pmeenan Thanks for the clarification. I'm going to open another PR to align docker configuration with the one used in prod |
claud-io
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.