Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling adjustment on Test History for Firefox #3020

Merged
merged 18 commits into from
Dec 22, 2023
Merged

Styling adjustment on Test History for Firefox #3020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b419c7f
Removing div and classes
Oct 31, 2023
4a39b10
Merge pull request #2995 from v-hclaveria/grid_lines_not_displaying_t…
claud-io Nov 9, 2023
c05fc6c
Scrollable cell for firefox
Nov 9, 2023
91796d6
Conflict resolved
Nov 10, 2023
058e28e
Merge branch 'grid_lines_not_displaying' into scrollbar_firefox
v-hclaveria Nov 10, 2023
efe1fe3
Display scrollbar only if necessary
Nov 10, 2023
b6bba52
Adjustment single div
Nov 10, 2023
c8e8cff
Fix format
Nov 16, 2023
9ea8328
Merge pull request #3005 from v-hclaveria/scrollbar_firefox
claud-io Nov 16, 2023
e0bf120
Styling adjustment on Test History for Firefox
Dec 5, 2023
7f00a1e
Format fix
Dec 5, 2023
6bc80ba
Merge branch 'grid_lines_not_displaying' into test_history_firefox
v-hclaveria Dec 6, 2023
73143ed
Scrollbar auto on table
Dec 19, 2023
b5f41cd
CSS class rename and selection
Dec 20, 2023
965ac5e
Use other css class
Dec 21, 2023
0fc6de8
Include span into scrollable div
Dec 21, 2023
802d18b
Apply suggestions from code review
claud-io Dec 22, 2023
992b2da
Apply suggestions from code review
claud-io Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions www/assets/css/pagestyle2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4517,6 +4517,10 @@ table.checklist td {
padding: 1rem;
}

.history th.idSelect {
vertical-align: baseline;
}

.history th.date,
.history td.date {
white-space: nowrap;
Expand Down Expand Up @@ -6643,6 +6647,20 @@ div.overflow-container > *,
position: relative;
}

.scrollableHistoryTable {
overflow: auto;
}

.scrollable-td {
padding: unset;
}

.scrollable-td-content {
overflow-x: auto;
padding: 1em;
padding-top: 0em;
}

span.units {
font-size: 0.5em;
font-weight: 300;
Expand Down
14 changes: 7 additions & 7 deletions www/resources/views/pages/testhistory.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
<div class="history-controls">
<input id="CompareBtn" type="submit" value="Compare Selected Tests">
</div>
<div class="scrollableTable">
<div class="scrollableHistoryTable">
<table id="history" class="history pretty" border="0" cellpadding="5px" cellspacing="0">
<thead>
<tr>
<th class="pin"><span>Select to compare</span></th>
<th><span>Select to compare</span></th>
<th class="url">URL</th>
<th class="date">Run Date</th>
<th class="location">Run From</th>
Expand All @@ -50,19 +50,19 @@
<tbody id="historyBody">
@foreach ($test_history as $record)
<tr>
<th><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
<td class="url"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></td>
<th class="idSelect"><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
<td class="url scrollable-td"><div class="scrollable-td-content"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></div></td>
<td class="date">{{ date_format(date_create($record->getStartTime()), 'M d, Y g:i:s A e') }}</td>
<td class="location">{{ $record->getLocation() }}</td>
<td class="location scrollable-td"><div class="scrollable-td-content">{{ $record->getLocation() }}</div></td>
<td class="label">{{ $record->getLabel() }}</td>
</tr>
@endforeach
</tbody>
@endif
</table>
</div>
claud-io marked this conversation as resolved.
Show resolved Hide resolved


claud-io marked this conversation as resolved.
Show resolved Hide resolved
claud-io marked this conversation as resolved.
Show resolved Hide resolved
@if ($local)
<input type="hidden" name="local" value="1">
@endif
Expand Down
14 changes: 8 additions & 6 deletions www/resources/views/pages/testhistoryadmin.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
'labelTxt' => $labelTxt,
])
<tr>
<th>
<th class="idSelect">
@if (isset($guid) && $video && !($url == "Bulk Test" || $url == "Multiple Locations test"))
<input type="checkbox" name="t[]" value="{{ $guid }}" title="First View">
@if ($repeat)
Expand All @@ -89,10 +89,12 @@
</b>
@endif
</td>
<td class="location">{!! $location !!}
@if ($video)
<span>(video)</span>
@endif
<td class="location scrollable-td">
<div class="scrollable-td-content">{!! $location !!}
@if ($video)
<span>(video)</span>
@endif
</div>
</td>
@if ($includeip)
<td class="ip">{{ $ip }}</td>
Expand All @@ -113,7 +115,7 @@
<td title="{{ $label }}" class="label">
<a href="{{ $link }}" id="label_{{ $guid }}">{{ $labelTxt }}</a>
</td>
<td class="url"><a title="{{ $url }}" href="{{ $link }}">{{ $shortURL }}</a></td>
<td class="url scrollable-td"><div class="scrollable-td-content"><a title="{{ $url }}" href="{{ $link }}">{{ $shortURL }}</a></div></td>
</tr>
@endforeach
</table>
Expand Down