feat: update go linter in CI

[rek]

Since my other branch is getting quite big, I thought I would split out some smaller PR's.

Here is one to make the lint go green. (it's mostly just running the auto-linter that CI uses locally)

Also:

• use the skip-cache suggestion from here
• Upgrade golangci-lint-action to v4.0.0

[rek]

i will add all this test stuff back in in my other PR, but since it's unused here, we are getting that lint warning.

[catdevman]

@rek what is the . for?

[rek]

$ golangci-lint run 

internal/service/folders/data_source.go:10:54: Comment should end in a period (godot)
	// "github.com/hashicorp/terraform-plugin-log/tflog"
	                                                    ^

It fixes this issue. But perhaps I should just remove that line instead.

[catdevman]

@rek I think it makes sense to just use make([]ClickUpTeamMemberDataSourceModel, len(members)) here and leave the capacity off it'll just get set the same automatically by make.

[rek]

This is trying to resolve this issue from golangci-lint run:

internal/service/teams/data_source.go:93:53: S1019: should use make([]ClickUpTeamMemberDataSourceModel, len(members)) instead (gosimple)
	result := make([]ClickUpTeamMemberDataSourceModel, len(members), len(members))

The problem with the gosimple suggestion is that it causes this further down the line:

internal/service/teams/data_source.go:117:12: append to slice `result` with non-zero initialized length (makezero)
		result = append(result, mem)

Here is the generated explanation:

there is a potential issue related to the use of make and append together, which could lead to unexpected results.

The line result := make([]ClickUpTeamMemberDataSourceModel, len(members)) creates a slice of ClickUpTeamMemberDataSourceModel with a length equal to len(members). This means that the slice result initially contains len(members) zero values.

Then, in the loop, you're using append to add elements to result. The append function does not replace the zero values, but adds new elements to the end of the slice. This means that after the loop, result will contain len(members) zero values, followed by the actual data.

I have changed that part now too, have a look and see what you think.