Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8.4 support #1130

Closed
jadeops opened this issue Nov 26, 2024 · 4 comments
Closed

php8.4 support #1130

jadeops opened this issue Nov 26, 2024 · 4 comments

Comments

@jadeops
Copy link

jadeops commented Nov 26, 2024

Information

  • Version of Medoo: v2.1.12
  • Version of PHP: 8.4
  • Type of Database: MySQL
  • System: Linux

Describe the Problem
lot of deprecated messages. there could be more.

PHP Deprecated:  Medoo\Medoo::exec(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /vendor/catfan/medoo/src/Medoo.php on line 515
PHP Deprecated:  Medoo\Medoo::dataMap(): Implicitly marking parameter $result as nullable is deprecated, the explicit nullable type must be used instead in /vendor/catfan/medoo/src/Medoo.php on line 1393
PHP Deprecated:  Medoo\Medoo::insert(): Implicitly marking parameter $primaryKey as nullable is deprecated, the explicit nullable type must be used instead in /vendor/catfan/medoo/src/Medoo.php on line 1671
PHP Deprecated:  Medoo\Medoo::id(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /vendor/catfan/medoo/src/Medoo.php on line 2134

Code Snippet

Expected Behavior
code runs without any deprecated messages

Actual Behavior
deprecated messages in logs

@catfan
Copy link
Owner

catfan commented Nov 28, 2024

Thank you for the feedback.

That's fixed on 6ef45a5.

@catfan catfan closed this as completed Nov 28, 2024
@jadeops
Copy link
Author

jadeops commented Nov 29, 2024

thanks, could you make a release please?

@adminko-svk
Copy link

make a release please

@catfan
Copy link
Owner

catfan commented Dec 22, 2024

I have made a pre-release version with this https://github.com/catfan/Medoo/releases/tag/v2.2.0-beta.

I may do more work on the next version afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants