Add false to error union at InputProps #511
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the Formik, it is common to use the following pattern
It is a very convenient way to pass the error. The expression formik.touched.holderName && formik.errors.holderName always returns a string or false. The component checks if the error is falsy and returns null in the error section if it is.
The only problem is when using the "strict" mode of TypeScript:
Type 'string | false | undefined' is not assignable to type 'string | undefined'.
I believe it's worth allowing the value "false" for these cases to work, but I don't think it makes sense to allow the Boolean type itself since the value "true" would likely be serialized and displayed on the screen.