Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon.jsx): Added icons outside the MUI, updating unit tests and … #586

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

MarcosViniciusPC
Copy link
Contributor

…typing

Description

https://jirasoftware.catho.com.br/browse/QTM-778

Review guide

  • Unit tests
  • Code review
  • TypeScript updated
  • Doc (yarn storybook)

rapahaeru
rapahaeru previously approved these changes Sep 19, 2024
Copy link
Contributor

@rapahaeru rapahaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one note, but all ok.

@rapahaeru rapahaeru added status:approved status:suggestion and removed status:reviewing Someone is reviewing this PR labels Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

@MarcosViniciusPC MarcosViniciusPC merged commit d9e14bb into master Sep 19, 2024
3 checks passed
@MarcosViniciusPC MarcosViniciusPC deleted the QTM-778 branch September 19, 2024 19:07
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 10.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants