Skip to content

Commit

Permalink
Cleaned up browser test output in CI (TryGhost#21462)
Browse files Browse the repository at this point in the history
no issue

- The browser test output in CI is really noisy, because the `NX_DAEMON`
doens't run in CI, but we're trying to use NX to watch and rebuild the
typescript modules. This is outputting a ton of "NX Daemon is not
running" type of errors, which make it difficult to sift through the
actual test results.
- We don't actually need to watch the typescript files, we just need to
build them once before starting. This is defined as an NX dependency for
the browser tests target, so we don't need to explicitly build the TS
packages at all. Removing the typescript watch & build command removes
the noisy errors, without impacting how the tests actually run.
  • Loading branch information
cmraible authored Oct 30, 2024
1 parent 30fc2f3 commit fe9b019
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/scripts/dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ if (DASH_DASH_ARGS.includes('ghost')) {
} else if (DASH_DASH_ARGS.includes('admin')) {
commands = [COMMAND_ADMIN, ...COMMANDS_ADMINX];
} else if (DASH_DASH_ARGS.includes('browser-tests')) {
commands = [COMMAND_BROWSERTESTS, COMMAND_TYPESCRIPT];
commands = [COMMAND_BROWSERTESTS];
} else {
commands = [COMMAND_GHOST, COMMAND_TYPESCRIPT, COMMAND_ADMIN, ...COMMANDS_ADMINX];
}
Expand Down

0 comments on commit fe9b019

Please sign in to comment.