Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catkin tools don't handle arch-specific library folders #154

Closed
scpeters opened this issue Mar 9, 2015 · 5 comments · Fixed by #156
Closed

Catkin tools don't handle arch-specific library folders #154

scpeters opened this issue Mar 9, 2015 · 5 comments · Fixed by #156
Labels
enhancement

Comments

@scpeters
Copy link
Contributor

scpeters commented Mar 9, 2015

Support for arch-specific library folders was added to catkin in ros/catkin#624 but it does not seem to be present in catkin tools. This is needed to build gazebo with catkin tools.
@wjwwood wjwwood mentioned this issue Mar 9, 2015
Open
13 tasks
@wjwwood
Copy link
Member

wjwwood commented Mar 9, 2015

Thanks for pointing this out, we'll have to port that functionality to catkin_tools, I'll put this issue on the list of things to do before recommending this over catkin_make_isolated: #90

@scpeters
Copy link
Contributor Author

scpeters commented Mar 9, 2015

I can take a crack at it, but it will take me a little while to find the time.

@wjwwood
Copy link
Member

wjwwood commented Mar 9, 2015

If you have time that'd be great, I could also take a stab at it, but it will also be a while before I have time to spend on it.

@jbohren
Copy link
Contributor

jbohren commented Mar 10, 2015

This is needed to build gazebo with catkin tools.

On which platforns / for which versions of Gazebo does this become necessary? I've been building Gazebo 2.x with catkin_tools ever since the 2.2.3 breakage.

@scpeters
Copy link
Contributor Author

Starting with gazebo2, the libraries are installed to ${prefix}/lib/x86_64-linux-gnu on my Ubuntu machine (due to GNUInstallDirs), so the LD_LIBRARY_PATH must be modified to include this extra folder.

scpeters added a commit to scpeters/catkin_tools that referenced this issue Mar 10, 2015
@scpeters
Add arch-specific library folders (catkin#154)
3243f66 
Try to detect arch-specific library folders using
gcc and dpkg-architecture, then add to
LD_LIBRARY_PATH and PKG_CONFIG_PATH.
Closes catkin#154.
Based on ros/catkin#624
@scpeters scpeters mentioned this issue Mar 10, 2015
Merged
scpeters added a commit to scpeters/catkin_tools that referenced this issue Mar 12, 2015
@scpeters
Add arch-specific library folders (catkin#154)
309d047 
Try to detect arch-specific library folders using
gcc and dpkg-architecture, then add to
LD_LIBRARY_PATH and PKG_CONFIG_PATH.
Closes catkin#154.
Based on ros/catkin#624
wjwwood added a commit that referenced this issue Mar 12, 2015
@wjwwood
Merge pull request #156 from scpeters/multiarch
454c94c 
Add arch-specific library folders (#154)
@wjwwood wjwwood mentioned this issue Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add arch-specific library folders (#154) scpeters/catkin_tools
3 participants
@wjwwood @jbohren @scpeters