Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fontawesome): init #1323

Closed
wants to merge 14 commits into from
Closed

feat(fontawesome): init #1323

wants to merge 14 commits into from

Conversation

trinkey
Copy link
Contributor

@trinkey trinkey commented Sep 17, 2024

🎉 Theme for Font Awesome 🎉

An svg icon library that kinda sucks but not as much as their website's css

💬 Additional Comments 💬

  • this websites uses variables. occasionally.
  • sometimes inline styles redefine variables
  • why are there so many inline styles
  • the inline styles don't stop help

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@trinkey trinkey requested a review from a team as a code owner September 17, 2024 23:08
@trinkey
Copy link
Contributor Author

trinkey commented Sep 17, 2024

404 page isn't styled ughhhhhhhhhhhhhh

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff on https://fontawesome.com/search?ip=classic&s=regular&o=r

image image

In modal on search page

image image (arrow buttons next/previous in modal)

https://docs.fontawesome.com/web/style/rotate:

image

(at bottom)
image

(sidebar active item background)

https://docs.fontawesome.com/web/style/mask:

image

https://docs.fontawesome.com/web/add-icons/upload-icons/icon-design:
image

Header and below text on https://docs.fontawesome.com/ (--sl-color-text-accent is unthemed)

scripts/userstyles.yml Outdated Show resolved Hide resolved
@trinkey
Copy link
Contributor Author

trinkey commented Nov 22, 2024

i see your feedback and will work on fixing these things when i have time but i'm like really busy right now, i'll hopefully get these done by tomorrow or saturday

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Nov 22, 2024
@trinkey
Copy link
Contributor Author

trinkey commented Nov 25, 2024

i'll hopefully get these done by tomorrow or saturday

ill do it tomorrow i swear

trinkey and others added 2 commits November 25, 2024 07:46
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@trinkey trinkey removed the waiting on author Note for staff that a re-review is not yet required label Nov 25, 2024
@uncenter
Copy link
Member

FYI the linter is failing.

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-12-24 at 13 03 32

These codeblock tabs look inverted. The mantle color should be used for the code backgorund and inactive tabs, and the lighter color should be used for the active tab maybe?

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Dec 24, 2024
@trinkey trinkey removed the waiting on author Note for staff that a re-review is not yet required label Dec 25, 2024
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few dark on dark buttons here.
image
image

We seem to have added our own backgrounds occasionally, which leads to wierd borders and strangely sized boxes.
image

When an icon is :active, it goes invisable
image

They also have code blocks, https://docs.fontawesome.com/apis/graphql/get-started, I do believe we have an expressive code port, well kind of https://github.com/expressive-code/expressive-code/blob/65e9b6b53936f53b147c1415a58d538e3aa3df35/docs/plugins/shiki-colorized-brackets/themes.js#L8 this is more of a in the future thing.

@trinkey
Copy link
Contributor Author

trinkey commented Dec 30, 2024

i'm not going to continue this style because the website is a hot mess and i don't "enjoy" (as much as you can enjoy writing css) theming it. might pick it up again but unlikely

@trinkey trinkey closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants