Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arch-linux): init #1381

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

claymorwan
Copy link

🎉 Theme for Arch user repository 🎉

The Arch user repository (aur) is a community-driven repository of packages for Arch Linux.
image

💬 Additional Comments 💬

I had a bit of struggle making this theme since it was my first time working with userstyles, but I made it in a day so it's fine. My only problem at the moment is changing the logo for a themed one, or at least a transparent one.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@claymorwan claymorwan requested a review from a team as a code owner October 16, 2024 23:09
@claymorwan claymorwan changed the title feat/arch-user-repository feat:arch-user-repository Oct 16, 2024
@claymorwan claymorwan changed the title feat:arch-user-repository feat: arch-user-repository Oct 16, 2024
@uncenter uncenter changed the title feat: arch-user-repository feat(arch-user-repository): init Oct 17, 2024
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
@GenShibe
Copy link
Contributor

In terms of the logo, my first thought is to take the SVG off of the arch wiki style, and then using that as a base to add the words "user repository"

@claymorwan
Copy link
Author

Well I already took the argo logo and changed the accent color, tho I haven't been able to insert it correctly and hide the original logo

Btw I think I gotta do a new commit to fix the requested changes or nah ? I don't do pr often so idk

claymorwan and others added 6 commits October 17, 2024 08:47
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@claymorwan
Copy link
Author

Ok I think I got everything fixed

@claymorwan claymorwan requested a review from uncenter October 17, 2024 09:05
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for the PR :).

It would be nice to theme visited links.

The red here is not catppuccin themed.
image

Package keywords are a bit hard to read, and would likely be worse if my accent matched the blue, could we use crust on those.
image

styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
claymorwan and others added 4 commits October 17, 2024 13:10
@claymorwan
Copy link
Author

I think I fixed everything now, tho idk about that conflict, tried to fix it by adding what was conflicting to the file

@claymorwan
Copy link
Author

I think I fixed everything now, tho idk about that conflict, tried something but didn't worked

@claymorwan
Copy link
Author

why's it broken again

@sgoudham sgoudham removed the request for review from mustafakhalaf-git October 25, 2024 19:19
@mustafakhalaf-git
Copy link
Member

I suggested combining the proposed Arch User Repository userstyle with the existing Arch Wiki userstyle to create a unified Arch Linux userstyle, and that is what we have now here.

Sounds good.

@claymorwan
Copy link
Author

So do I have to do stuff again for the pr or nah ?

@uncenter
Copy link
Member

So do I have to do stuff again for the pr or nah ?

Nothing right now, just needs reviewing.

@claymorwan
Copy link
Author

So do I have to do stuff again for the pr or nah ?

Nothing right now, just needs reviewing.

Oki, I'll be waiting then

@claymorwan
Copy link
Author

O wairt bu reviewing does that mean Inhabe to do the "request review" thingy

@uncenter
Copy link
Member

uncenter commented Nov 1, 2024

Nope, nothing you need to do right now.

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text colour here should be subtext0
{D996B83F-1B89-419D-A3DB-374859302DEF}
reproduction link: https://archlinux.org/news/mkinitcpio-hook-migration-and-early-microcode/

This should be text, its on the main page
{6C306493-EBA5-4B68-85F6-781235E1ABA0}

The green here is wrong
{D66140C1-CBA0-4E62-9BC6-81C552617F45}
repro link: https://archlinux.org/packages/extra/x86_64/syslog-ng/

Link hover shouldn't be so grey
{6C279845-0ED4-4DF7-B0FD-84901E6BF916}
repro url: https://bbs.archlinux.org/viewforum.php?id=23

the wiki seems to have some issues with the icons
{EC6D616A-1032-4579-9476-90686C25F19E}

@claymorwan
Copy link
Author

The text colour here should be subtext0

Fixed that.

This should be text, its on the main page

I can't change that one, for some reason only 2 pages has the .anb-selected class name, so until they add it to all pages I can't do something about it (unless there's another that idk). In the meantime I changed them all to subtext0 and the selected one will have to be page's white text color.

The green here is wrong

Couldn't find the class name or id for it cuz idk where to find a recently updated package (this green text doesn't seems to be on the aur).

Link hover shouldn't be so grey

Istg I tried everything, but I can't change that hover color, I an changer the background color on hover but not the text color.

the wiki seems to have some issues with the icons

These are on the wiki page and were already broken with the old arch wiki theme. I tried to fixed them but couldn't.

@uncenter
Copy link
Member

Please stop updating this branch it pings everyone involved.

@claymorwan
Copy link
Author

claymorwan commented Nov 11, 2024

O sorry, I thought I was supposed it keep it updated, my bad

@uncenter uncenter requested a review from isabelroses November 16, 2024 02:32
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On archwiki this seems broken.
image

Also the current archwiki themes the active navbar page with the accent colour.
image

Hovering links also looks somewhat poor, perhaps we could darken the accent colour?

@claymorwan
Copy link
Author

On archwiki this seems broken. image

If u're talking about the icon then I can't change that, it was like that with the old arch wiki theme and I haven't found a way to change it

Also the current archwiki themes the active navbar page with the accent colour. image

If you're talking about changing the white to accent color, I can only do that to like 2-3 of the pages, cuz these have a class name for when they're selected, the other pages doesn't tho

Hovering links also looks somewhat poor, perhaps we could darken the accent colour?
So like change the hover color to every link ?

@Covkie
Copy link
Contributor

Covkie commented Dec 17, 2024

Homepage RSS feed buttons and current tab
image
image

Visited pages highlight, language picker on the wiki & unthemed buttons for the dark mode selector and sidebar dropdown
image

Speaking of the dark mode selector. The wiki is the only page that has one so it would make sense to respect it if it's set to dark otherwise use the user's set theme?

@claymorwan
Copy link
Author

claymorwan commented Dec 19, 2024

Homepage RSS feed buttons and current tab image image

I tried to change that but it doesn't wanna idk what to do

Visited pages highlight, language picker on the wiki & unthemed buttons for the dark mode selector and sidebar dropdown image

I should be able to change the highlights, language picker, tho same problem for the button as the RSS idk how to do it

Speaking of the dark mode selector. The wiki is the only page that has one so it would make sense to respect it if it's set to dark otherwise use the user's set theme?

How do I even do that

I'll try to get to it next week, I'm still in my exams week but in vacation next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wiki Arch Wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants