refactor(treewide): cleanup and use rgbify mixin #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
anilist
uncenter
force-pushed
the
color-value-stuff
branch
from
66728d6 to
ffb44f0
Compare
uncenter
commented
Dec 21, 2024
There was a problem hiding this comment.
Proton and Snapchat Web are the only two that actually need to be tested, the rest are negligible changes. For these two though the format goes from space separated values to comma separated values, which can break things iirc depending on how the website uses the variable.
uncenter
requested review from
FrancoRav,
ryanccn,
Dandraghas,
trinkey,
comfysage,
Tnixc,
NeonGamerBot-QK,
AnubisNekhet,
Nyatalieeee,
Gandalf-the-Blue,
GenShibe,
r58Playz and
stellophiliac
as code owners
|
Sorry for the pings! Not much to look at here, couldn't figure out how to disable them 😓 |
trinkey
approved these changes
Dec 24, 2024
isabelroses
approved these changes
Dec 24, 2024
Nyatalieeee
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
hslifymixin to match the functionality of thergbifymixin (extract color values) - not used yet but I did needeto use it for #1510. Also simplifies the existingrgbifymixin and inserts it in places where we should be using it (technically might not be the exact same since the comma vs space separated rgb syntax is weird, will have to check).